Skip to content

ignore invalid module search param in deploy page #5396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2024
Merged

ignore invalid module search param in deploy page #5396

merged 1 commit into from
Nov 12, 2024
+19 −8

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 12, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on updating the handling of the module search parameter in two components, allowing it to accept either an array or a single string. This change simplifies the logic for processing the module parameter and ensures consistent behavior.

Detailed summary

  • Updated the type of module in searchParams to accept string[] | string.
  • Changed the logic to handle searchParams.module:
    • If it's a string, wrap it in an array.
    • If it's an array, use it directly.
  • Ensured modules is initialized to an empty array if no valid modules are found.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f31801e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review November 12, 2024 17:43
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 12, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Nov 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Nov 12, 2024 — with Graphite App
@MananTank Graphite App
Copy link
Member Author

MananTank commented Nov 12, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 12, 12:43 PM EST: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 12, 2:47 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 12, 3:04 PM EST: A user merged this pull request with the Graphite merge queue.

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 12, 2024 17:43 Inactive
@vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 8:03pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 12, 2024 8:03pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 12, 2024 8:03pm
wallet-ui ⬜️ Skipped (Inspect) Nov 12, 2024 8:03pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 12, 2024 17:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 12, 2024 17:43 Inactive
@codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.33%. Comparing base (ef56304) to head (f31801e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5396   +/-   ##
=======================================
  Coverage   45.33%   45.33%           
=======================================
  Files        1067     1067           
  Lines       55405    55405           
  Branches     4015     4015           
=======================================
  Hits        25116    25116           
  Misses      29602    29602           
  Partials      687      687
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ef56304
packages 40.35% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.15 KB (0%) 883 ms (0%) 143 ms (+67.71% 🔺) 1.1 s
thirdweb (cjs) 104.69 KB (0%) 2.1 s (0%) 201 ms (+5.44% 🔺) 2.3 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 36 ms (+378.13% 🔺) 151 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 15 ms (+447.67% 🔺) 25 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 59 ms (+220.66% 🔺) 434 ms

@MananTank MananTank force-pushed the 11-12-ignore_invalid_module_search_param_in_deploy_page branch from 79ad1f2 to 6ecee85 Compare November 12, 2024 19:32
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 12, 2024 19:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 12, 2024 19:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 12, 2024 19:32 Inactive
@MananTank MananTank requested a review from jnsdls November 12, 2024 19:33
@MananTank
ignore invalid module search param in deploy page (#5396)
f31801e 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the handling of the `module` parameter in the `searchParams` to support both an array and a string. It ensures that the code correctly processes the `module` regardless of its type.

### Detailed summary
- Updated `module` type in `searchParams` to allow both `string[]` and `string`.
- Modified the logic to handle `searchParams.module` as a string or an array.
- Ensured that `modules` is derived correctly from `moduleParam`, defaulting to an empty array if no valid modules are found.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 11-12-ignore_invalid_module_search_param_in_deploy_page branch from 6ecee85 to f31801e Compare November 12, 2024 19:52
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 12, 2024 19:52 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 12, 2024 19:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 12, 2024 19:52 Inactive
@graphite-app graphite-app bot merged commit f31801e into main Nov 12, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the 11-12-ignore_invalid_module_search_param_in_deploy_page branch November 12, 2024 20:04
@vercel vercel bot temporarily deployed to Production – docs-v2 November 12, 2024 20:04 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 12, 2024 20:04 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 12, 2024 20:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard. hotfix This pull request should be prioritized in the merge queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls